Fix Plugin Initialization for Non-existent Model Data#461
Merged
yangbobo2021 merged 1 commit intomainfrom Mar 2, 2024
Merged
Conversation
- Wrap configuration update calls in try-catch to catch and log errors - Ensure plugin initialization continues despite non-existent model data - Log errors using `logger.channel()` for easier debugging and monitoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where the plugin fails to initialize due to the inability to write to non-existent model data, particularly in specific versions of VSCode.
Changes include a try-catch block to handle configuration update calls gracefully during initialization. This ensures that plugin startup isn't halted by these exceptions. Additionally, any encountered errors are logged using
logger.channel()to facilitate easier debugging and monitoring.The proposed fix will skip the problematic data migration during initialization as a temporary measure until the new plugin version with internal configuration UI is released.
By merging this PR, we can ensure that the plugin remains functional across various versions of VSCode without disrupting the user experience.
Closes devchat-ai/devchat#280