Fix staged file deletion flag display in commit workflow#51
Merged
Conversation
- Added a letter before each modified file to indicate the modification status - Updated the workflow to display file deletion flag in 'Staged' files - Fixed the issue where staged files did not display the git status
- Fixed lint error in commit/commit.py file - Updated unstaged_files_show assignment for lint compliance - Updated subprocess.check_output call for lint adherence
kagami-l
reviewed
Jan 24, 2024
kagami-l
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a visual indicator for the modification status of each staged file, particularly to show a deletion flag (D) when files are marked for deletion, in order to align with common Git conventions as seen in VSCode Source Control.
This change should make the modification status for each file more transparent and intuitive for users during the staging phase of the commit process.
Closes devchat-ai/devchat#197
staged flags:
M: modify
A: new Add file
D: delete file
unstaged flags:
M: modify
U: new file
D: delete file
looks like: