Fix keybase.io infinite loop: install function recursively calls itself#150
Merged
Fix keybase.io infinite loop: install function recursively calls itself#150
install function recursively calls itself#150Conversation
…function Co-authored-by: sebst <592313+sebst@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/2c9d072e-dae2-4e7b-a797-6e435a5c9005
Copilot
AI
changed the title
[WIP] Fix infinite loop issue in keybase.io feature during test
Fix keybase.io infinite loop: Mar 21, 2026
install function recursively calls itself
sebst
requested changes
Mar 21, 2026
Member
sebst
left a comment
There was a problem hiding this comment.
install.sh changed but version in devcontainer-feature.json not increased. increase minor version here
Co-authored-by: sebst <592313+sebst@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/33ff4970-054e-437b-9da7-2652ef4ad6a5
Contributor
Author
Done — bumped version from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
install()bash function insrc/keybase.io/install.shcalledinstall -m 0755 /dev/stdin /usr/local/bin/keybaseinternally — but bash resolves function names before external commands, so this recursively re-enteredinstall()instead of calling/usr/bin/install, causing an infinite loop.Changes
src/keybase.io/install.sh: Replace bareinstallwithcommand installto explicitly invoke the external binary and bypass bash's function lookup.Original prompt
keybase.ioseems to be stuck in an infinite loop during test #149⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.