Skip to content

Conversation

@szkiba
Copy link
Contributor

@szkiba szkiba commented Feb 20, 2025

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Description

Adding Grafana Labs Dev Container Features to the public index (k6, xk6)

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@szkiba szkiba requested a review from a team as a code owner February 20, 2025 07:40
@Kaniska244
Copy link

Thanks for the PR!
Change approved. This can be merged.

ddoyle2017
ddoyle2017 previously approved these changes Feb 24, 2025
Copy link

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⚡

@szkiba
Copy link
Contributor Author

szkiba commented Mar 10, 2025

Hi @ddoyle2017 ,

Can you help me merge this PR? Do I need to do anything to get the PR merged?

@ddoyle2017
Copy link

ddoyle2017 commented Apr 9, 2025

Hi @ddoyle2017 ,

Can you help me merge this PR? Do I need to do anything to get the PR merged?

@szkiba Changes approved! I can help merge this in after the conflicts are addressed

@szkiba
Copy link
Contributor Author

szkiba commented Apr 10, 2025

Hi @ddoyle2017, I accidentally closed the PR (during upstream sync).
I opened a new one with the same content:
#545
Can you help me merge this please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants