-
Notifications
You must be signed in to change notification settings - Fork 542
Add feature for copilot-cli #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andyfeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for raising this up, @devm33! 🙌 Handful of thoughts / suggestions / questions
andyfeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you don't refactor the version parsing logic, I think this is a perfect 1.0.0 start, @devm33 🙌
AlvaroRausell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern I have is not being able to pin a particular version, since this is a common pattern in different features. Is there a chance you could add something to support a version other than latest or prerelease?
Sure thing I can add pinning to a specific. Just didn't want to do a bunch of semver parsing :) |
Done 008ff14 |
Tested with:
devcontainer features test --skip-scenarios -f copilot-cli -i ubuntu:noble