Skip to content

Conversation

@devm33
Copy link
Contributor

@devm33 devm33 commented Dec 5, 2025

Tested with:

devcontainer features test --skip-scenarios -f copilot-cli -i ubuntu:noble 

@devm33 devm33 marked this pull request as ready for review December 5, 2025 21:21
@devm33 devm33 requested a review from a team as a code owner December 5, 2025 21:21
Copy link

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for raising this up, @devm33! 🙌 Handful of thoughts / suggestions / questions

Copy link

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if you don't refactor the version parsing logic, I think this is a perfect 1.0.0 start, @devm33 🙌

Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern I have is not being able to pin a particular version, since this is a common pattern in different features. Is there a chance you could add something to support a version other than latest or prerelease?

@devm33
Copy link
Contributor Author

devm33 commented Dec 8, 2025

One concern I have is not being able to pin a particular version, since this is a common pattern in different features. Is there a chance you could add something to support a version other than latest or prerelease?

Sure thing I can add pinning to a specific. Just didn't want to do a bunch of semver parsing :)

@devm33
Copy link
Contributor Author

devm33 commented Dec 8, 2025

One concern I have is not being able to pin a particular version, since this is a common pattern in different features. Is there a chance you could add something to support a version other than latest or prerelease?

Sure thing I can add pinning to a specific. Just didn't want to do a bunch of semver parsing :)

Done 008ff14

@AlvaroRausell AlvaroRausell merged commit b950373 into devcontainers:main Dec 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants