Go - Adds /go/bin to PATH#162
Merged
samruddhikhandale merged 4 commits intoSep 16, 2022
Merged
Conversation
samruddhikhandale
changed the title
/go/bin to PATH
joshspicer
approved these changes
Sep 16, 2022
joshspicer
left a comment
joshspicer
left a comment
Member
There was a problem hiding this comment.
Looks good to me - I especially like the scenarios added here to exercise slightly more complex cases 🚀
@yuku - I believe you shared some go insights with us over on vscode-dev-containers. Would love your opinion on if these container envs all look good :)
samruddhikhandale
deleted the
samruddhikhandale/go-remove-target_go_path
branch
This was referenced Sep 16, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #159
gois installed at/usr/local/go/binand the go tools are installed at/go/bin. UpdatedcontainerEnvto reflect the same.Also, removed
updateRcwhich updatedGOROOT,GOPATHandPATH(containerEnvalready updates that)