[git] - Fixing issue for alpine installation from source and updating tests#1679
Merged
Merged
Conversation
2dc4bba to
f2ed09e
Compare
abdurriq
reviewed
Jun 30, 2026
abdurriq
previously approved these changes
Jun 30, 2026
abdurriq
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure. This PR fixes a build failure when installing Git from source on Alpine by adding the missing
linux-headersdependency, and hardens the install script to fail loudly if the build doesn't succeed (instead of silently reporting "Done!"). It also overhauls thegitfeature's test matrix — adding a "version-is-latest" assertion, replacing the obsolete CentOS 7 test with Debian Bookworm/Trixie scenarios, and bumping the feature version to1.3.7.Key changes
1. The core fix —
src/git/install.shlinux-headersto the Alpine build dependencies (the missing package that caused the source build to fail).maketo the RHEL dependency list.makebuild result and exits with an error + message if the build fails, rather than always printingDone!:2. Version bump —
src/git/devcontainer-feature.json1.3.6→1.3.7.3. Test improvements (
install_git_from_src*.shfor default, alpine, noble)get_latest_git_version(queries the GitHub tags API) andcheck_git_is_latest_version, plus a newversion-is-latestcheck to assert the installed Git matches the latest stable release.4. Test scenario matrix —
test/git/scenarios.jsoninstall_git_from_src_centos-7scenario (and deletesinstall_git_from_src_centos-7.sh).install_git_from_src_bookworm(debian:bookworm) andinstall_git_from_src_trixie(debian:trixie) scenarios, with the new test files symlinking toinstall_git_from_src.sh.ubuntu:nobletoubuntu:resolute.Test Coverage
New assertions added
version-is-latestcheck is added to the default, alpine, and noble source-install tests. It resolves the latest stable Git tag from the GitHub API and asserts the installed binary matches:Scenario / platform coverage changes
install_git_from_src(default)ubuntu:nobleubuntu:resoluteinstall_git_from_src_centos-7centos:centos7install_git_from_src_bookwormdebian:bookworminstall_git_from_src_trixiedebian:trixieinstall_git_from_src_alpineversion-is-latestcheckinstall_git_from_src_noblelatest versioncheckCoverage assessment
check_git_is_latest_versionmakes an unauthenticated GitHub API call, which can hit rate limits in CI and cause flaky failures.