Fix CI: ruff format oom_dedup.py + document ruff format --check#137
Merged
Conversation
CI's "Ruff (format check)" step (`ruff format --check`, ruff 0.15.18) has been red since the first oom_dedup edit: that file was lint-clean (`ruff check` passes) but not format-clean, and I only ran `ruff check` locally. The diff is purely cosmetic (ruff collapsing/exploding multi-arg calls in the recently-added _cap_lines / classify / load_snapshot code) -- no behavior change; the oom_dedup suite stays green. - `ruff format fusil/python/oom_dedup.py` -> whole tree now format-clean (106 files). - CLAUDE.md: note CI runs BOTH `ruff check` AND `ruff format --check`, so both must be run before pushing (`ruff check` passing does not imply format-clean). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136.
CI's
ruff format --checkstep has been red since the firstoom_dedup.pyedit — the file was lint-clean but not format-clean, and onlyruff checkwas run locally. The reformat is purely cosmetic (ruff collapsing/exploding multi-arg calls in the recently-added_cap_lines/classify/load_snapshotcode); behavior unchanged and the oom_dedup suite stays green (52 tests).ruff format fusil/python/oom_dedup.py→ whole tree format-clean (106 files).ruff checkandruff format --check, so both must pass before pushing.Verified locally (ruff 0.15.18, the CI pin):
ruff check✓,ruff format --check✓ (106 files already formatted), full suite 326 passed / 32 skipped.🤖 Generated with Claude Code