Skip to content

Update skript_repo_ref to 2.15.0-pre1 and remove obsolete scripts#15

Merged
devdinc merged 7 commits intodevfrom
2.15
Apr 2, 2026
Merged

Update skript_repo_ref to 2.15.0-pre1 and remove obsolete scripts#15
devdinc merged 7 commits intodevfrom
2.15

Conversation

@devdinc
Copy link
Copy Markdown
Owner

@devdinc devdinc commented Apr 2, 2026

Summary by CodeRabbit

  • Breaking Changes
    • Removed Persistent Data Container (PDC) utility library and all associated functionality for data storage operations.
  • Tests
    • Removed test suite for PDC functionality.
  • Documentation
    • Removed Persistent Data Container documentation.
  • Chores
    • Updated test workflow configuration to reference new version baseline.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cfdc77bb-c439-41b3-9ffc-da3c93142582

📥 Commits

Reviewing files that changed from the base of the PR and between 620dac2 and 1bf86a5.

📒 Files selected for processing (1)
  • docs/pdc.md
💤 Files with no reviewable changes (1)
  • docs/pdc.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: run-tests

Walkthrough

This PR removes the Persistent Data Container (PDC) utility library, including its implementation file, comprehensive test suite, and documentation. Additionally, a workflow configuration updates the Skript test source reference version.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test-skripts.yml
Updated skript_repo_ref input from dev/feature to 2.15.0-pre1 for test execution.
PDC Library Removal
scripts/libs/pdc.sk
Deleted entire PDC utility library containing custom expressions for namespaced key access, persistent data type mappings, container creation/extraction, and serialization logic for primitive and object types.
PDC Tests Removal
tests/working/libs/pdc.test.sk
Removed complete test suite covering PDC typed get/set operations, deletion semantics, object serialization, and edge cases across multiple data types.
PDC Documentation Removal
docs/pdc.md
Deleted documentation describing PDC expression syntax, usage patterns, type handling, and serialization behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Create tests for pdc.sk #10: Adds tests for pdc.sk functionality that this PR removes entirely, representing inverse operations on the same PDC feature set.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating the Skript repository reference to 2.15.0-pre1 and removing obsolete PDC-related scripts and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2.15

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df21fc7a-6aa1-498f-abcb-a9acdabaa2aa

📥 Commits

Reviewing files that changed from the base of the PR and between 547e1b0 and 620dac2.

📒 Files selected for processing (5)
  • .github/workflows/test-skripts.yml
  • scripts/libs/pdc.sk
  • scripts/libs/routines.sk
  • tests/working/libs/pdc.test.sk
  • tests/working/libs/routines.test.sk
💤 Files with no reviewable changes (4)
  • tests/working/libs/pdc.test.sk
  • tests/working/libs/routines.test.sk
  • scripts/libs/routines.sk
  • scripts/libs/pdc.sk

Comment thread .github/workflows/test-skripts.yml
@devdinc devdinc merged commit 7b48f84 into dev Apr 2, 2026
2 checks passed
@devdinc devdinc deleted the 2.15 branch April 18, 2026 07:36
devdinc added a commit that referenced this pull request Apr 18, 2026
* Update skript_repo_ref to 2.15.0-pre1 and remove obsolete scripts (#15)

* Update skript_repo_ref to version 2.15.0-pre1

* Delete scripts/libs/pdc.sk

* Delete tests/working/libs/pdc.test.sk

* Delete tests/working/libs/routines.test.sk

* Delete scripts/libs/routines.sk

* Delete docs/pdc.md

* Update test action and Skript version in workflow

* Refactor key assignment for SectionNode instances

* Include current script in test failure tracking

* Improve error reporting in test framework

* Revert error specification in test framework

* Trying to understand why last parse logs don't work

* Fix test failure message formatting in testframework.sk

* Try to understand once again.

* Fix invalid %

* Remove last parse logs test

* Add back the test case for last parse logs, but only in the workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant