Bugfix sorting #32
Closed
Bugfix sorting #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 10, 2022 23:50
sbmsr
reviewed
May 13, 2022
Comment on lines
+15
to
+26
| const sortProducts = (name) => { | ||
| let optionsArr = [...sortOptions]; | ||
| optionsArr.map((item) => { | ||
| if (item.name === name) { | ||
| // switch on the sorting method clicked by user | ||
| item.current = true; | ||
| } | ||
| // switch off a previously selected sorting method if it had been selected | ||
| else item.current = false; | ||
| }); | ||
| setSortOptions((prevState) => optionsArr); | ||
| }; |
Member
There was a problem hiding this comment.
praise: I like how you separated the logic into a method, and simply call it below in the click handler. Good work!
sbmsr
reviewed
May 13, 2022
| for (let i = 0; i < sortOptions.length; i++) { | ||
| if (sortOptions[i].current === true) { | ||
| if (sortOptions[i].name === "Price") { | ||
| console.log("sorting by price"); |
Member
There was a problem hiding this comment.
nitpick: please remove console.log
sbmsr
reviewed
May 13, 2022
| } | ||
| } | ||
| setProducts((prevState) => sortedProducts); | ||
| }, [sortOptions]); |
Member
There was a problem hiding this comment.
praise: Good work tying this logic to changes to the sortOptions dependency.
sbmsr
approved these changes
May 13, 2022
Member
sbmsr
left a comment
sbmsr
left a comment
There was a problem hiding this comment.
As usual, good work Animan. Clean code with good separation of logic from view code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created sorting functionality via a sorting function in a useState that has the sortOptions as a dependency. There might be a more concise way to write out the sorting function that is more performant, I was having trouble getting a Javascript Array method that could work for this case.