true portable test workflow update and lib issue fixed#1
Merged
Conversation
…PHP extension extraction
- Added comprehensive portability testing scripts for Linux, macOS, and Windows to validate that UBuilder-generated executables can run without host runtime dependencies. - Created `PORTABILITY_IMPLEMENTATION_SUMMARY.md` to document the testing framework, including CI/CD integration and expected outcomes. - Developed individual test scripts: `test-examples-linux-no-runtime.sh`, `test-examples-macos-no-runtime.sh`, and `test-examples-windows-no-runtime.bat` to simulate environments without PHP, Python, and Node.js. - Enhanced CI/CD workflows to utilize the new portability test scripts, ensuring automated validation of portability claims on each commit. - Provided detailed documentation in `PORTABILITY_TESTING.md` outlining usage, expected results, and troubleshooting for the portability testing process.
…g and cross-platform compatibility
There was a problem hiding this comment.
Pull Request Overview
This PR enhances UBuilder's portability testing and runtime embedding by adding dedicated cross-platform scripts, refining PHP runtime configuration, and improving error handling.
- Adds comprehensive Windows, macOS, and Linux scripts to simulate missing host runtimes and validate executable portability.
- Updates
runtime_embedder.cto disable PHP extensions by default, adjust error reporting, and enlarge extension path buffer. - Improves core functions in
runtime_manager.candubuilder.cwith unused-parameter suppression and more robustchdir/systemerror handling; integrates portability tests into the CI workflow.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/runtimes/runtime_manager.c | Suppress unused argc/argv warnings in runtime_execute |
| src/runtimes/runtime_embedder.c | Disable PHP extensions, refine error reporting, increase ext_path buffer |
| src/core/ubuilder.c | Suppress unused params, improve chdir and system error handling |
| examples/.sh / examples/.bat | Introduce cross-platform portability test scripts |
| .github/workflows/ci.yml | Integrate portability test scripts into CI pipeline |
Comments suppressed due to low confidence (1)
src/runtimes/runtime_embedder.c:392
- [nitpick] The new explanatory block at lines 392-395 overlaps with the subsequent "EXTENSIONS EMBEDDED BUT NOT LOADED" section; consider consolidating these comments to avoid duplication and improve readability.
strcat(php_ini_content, "\n; EXTENSIONS COMPLETELY DISABLED FOR PORTABILITY\n");
developersharif
added a commit
that referenced
this pull request
May 19, 2026
Adds a status snapshot at the top so next session sees what's done vs still open without scanning commit history. Items #4 (PHP hermetic), #5 (arm64/macOS), #7 (ubuilder init) remain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.