Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate bandit execution to
lhoupert/bandit-actionIntent
Previously, the action ran bandit as a raw Python subprocess and parsed the JSON output itself.
This PR replaces that with a proper GitHub Action step —
lhoupert/bandit-action— which runsbandit and produces a SARIF file. The Python module then reads the SARIF output for reporting.
This is a cleaner separation of concerns: the action step handles execution (with GitHub's native
SARIF integration), and the Python layer handles aggregation and reporting only.
What changed
action.yml— adds alhoupert/bandit-actionstep that runs before the Python module.The
bandit_scan_dirsandbandit_severity_thresholdinputs are now passed directly to thatstep instead of being forwarded to the Python code.
runners.py— replacesrun_bandit()(subprocess call → JSON parse) withread_bandit_sarif()(reads the SARIF file left by bandit-action and normalises it into thesame internal dict shape).
settings.py— dropsbandit_scan_dirs(no longer needed at the Python level), addsbandit_sarif_path, normalises severity values to lowercase.Tests — updated to cover the SARIF reading path; new
bandit_clean.sarifandbandit_issues.sariffixtures replace the old JSON ones.README.md— rewritten to explain the action's value over using bandit or pip-auditdirectly, with a concrete PR comment example and blocking threshold reference tables.