Skip to content

Conversation

@maxrjones
Copy link
Member

No description provided.

@maxrjones maxrjones requested a review from kylebarron October 22, 2025 20:41
@maxrjones
Copy link
Member Author

@kylebarron
Copy link
Member

We can't just remove the symlink because that's what's providing the type hints for store classes. The type definition is defined in this folder in obstore, and we don't want to duplicate the type definitions here, because they'll get out of sync.

If we delete the symlink, no Python users on any platform will get any type hinting when they try to create stores via async_tiff.store

Ideally the solution would be something like resolving the symlink as part of the windows build process or something like that.

@kylebarron
Copy link
Member

Or we could even just delete the symlink file as part of the build process on Windows, and then only Windows users won't get type hints, but I don't want to delete the symlink overall.

@maxrjones
Copy link
Member Author

does the symlink for type hints only work when installed from the wheels? I tested this out on main where the symlink remains and do not get type hints when using async_tiff stores, whereas I do for obstore stores.

@kylebarron
Copy link
Member

Checking it out locally, it looks like that symlink is broken now; I'm not sure why.

From async-tiff/python/python/async_tiff you should be able to ls store and have it show you the .pyi files.

This worked at one point I'm pretty sure but I'm not sure what's going wrong now and I don't have time to dig into it.

@maxrjones
Copy link
Member Author

maxrjones commented Oct 22, 2025

The symlinks work locally after running git submodule update --init --recursive. I updated the PR to only remove the symlink for the windows build. That seems to work -https://github.com/developmentseed/async-tiff/actions/runs/18730296413/job/53425377307

@maxrjones maxrjones changed the title Remove symlink that doesn't work for windows Remove broken symlink when building windows wheels Oct 23, 2025
@maxrjones
Copy link
Member Author

@kylebarron do you mind if I merge this and trigger a release? This PR unblocks integration with virtualizarr (xref zarr-developers/VirtualiZarr#810)

python-version: 3.13
architecture: ${{ matrix.platform.target }}
- name: Remove symlink (not supported in Windows wheels)
run: Remove-Item -Path python/python/async_tiff/store -Force
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows syntax is so weird 😄

@kylebarron
Copy link
Member

Thanks!

Let me put up another PR quickly that opts in to abi3 wheels, which should make wheel builds faster

@kylebarron kylebarron merged commit ef2381e into main Oct 23, 2025
20 checks passed
@kylebarron kylebarron deleted the max/windows-wheels branch October 23, 2025 15:00
@weiji14 weiji14 mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants