-
Notifications
You must be signed in to change notification settings - Fork 3
Remove broken symlink when building windows wheels #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
wheels were tested in https://github.com/developmentseed/async-tiff/actions/runs/18728327788 |
|
We can't just remove the symlink because that's what's providing the type hints for store classes. The type definition is defined in this folder in obstore, and we don't want to duplicate the type definitions here, because they'll get out of sync. If we delete the symlink, no Python users on any platform will get any type hinting when they try to create stores via Ideally the solution would be something like resolving the symlink as part of the windows build process or something like that. |
|
Or we could even just delete the symlink file as part of the build process on Windows, and then only Windows users won't get type hints, but I don't want to delete the symlink overall. |
|
does the symlink for type hints only work when installed from the wheels? I tested this out on main where the symlink remains and do not get type hints when using |
|
Checking it out locally, it looks like that symlink is broken now; I'm not sure why. From This worked at one point I'm pretty sure but I'm not sure what's going wrong now and I don't have time to dig into it. |
|
The symlinks work locally after running |
|
@kylebarron do you mind if I merge this and trigger a release? This PR unblocks integration with virtualizarr (xref zarr-developers/VirtualiZarr#810) |
| python-version: 3.13 | ||
| architecture: ${{ matrix.platform.target }} | ||
| - name: Remove symlink (not supported in Windows wheels) | ||
| run: Remove-Item -Path python/python/async_tiff/store -Force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows syntax is so weird 😄
|
Thanks! Let me put up another PR quickly that opts in to abi3 wheels, which should make wheel builds faster |
No description provided.