Conversation
a017f0e to
2044ca6
Compare
nerik
left a comment
There was a problem hiding this comment.
This is looking amazing 🙏
One thing that I think was problematic with the collapsable panels is that you could easily end up in that "empty" state:
So I tweaked the panel behavior a little bit:
- You can't collapse a panel anymore if it's the only one visible
- The app now opens with only the 'attendees' panel opened. The app seemed like a lot to take in at first load.
- Clicking the 'done' button now opens the 'locations' in its entirety.
Thoughts @LanesGood
|
@nerik thanks for these changes and the improvements to the panel state. One slight suggested change: what if we had both panels open by default, but have the "Add at least 2 attendees to show results" line in the |
There was a problem hiding this comment.
Fantastic work @LanesGood! I love the new UI layout and functionality.
Using @nerik's globe map style, I stress-tested this with 694 participants. Co2ordinate handles it very well 😄. It'd be nice to test with your map style.
Co2ordinate.stress.test.mp4
wrynearson
left a comment
There was a problem hiding this comment.
However, I did find that the attendees checkbox status wasn't in sync when the select/deselect all members from group X functionality was used.
Co2ordinate.attendee.selection.bug.mp4
Show both tabs at mount Co-authored-by: Lane Goodman <lane@developmentseed.org> Update src/components/Planner.tsx Co-authored-by: Lane Goodman <lane@developmentseed.org>
db96c8f to
ce2fe15
Compare
|
@wrynearson Thanks for reporting, tracking these here: |

This contains a big commit for style and layout updates. This PR:
AttendeesandMeeting LocationsName + Groupfor attendees,Location + IATA code + Country + Flagfor locationsA few notes:
The Popup is not inheriting the DevSeed theme UI - I'm not sure what the solution is here. Wrapping the Popup component in the ThemeProvider did not fix thisfixed!