Revert PR #125#126
Merged
Merged
Conversation
Contributor
|
✨ Preview deployed to S3! Visit http://ds-preview-contributor-network-126.s3-website-us-west-2.amazonaws.com/ |
4 tasks
aboydnw
added a commit
that referenced
this pull request
May 5, 2026
Honestly not sure what happened with #125 I was adding another commit to fix the deploy error manually from vs code and next thing I look up and it says I merged it. I checked claude code output and didn't see anything that said merge, which is also not one of the actions I have given it permission to do. Anyways, I created and merged #126 to revert it and then created this pr for you to review. Let me know if that's the not the appropriate steps to take, in case I run into this situation again. ## NPM module and PyPi publication Makes the previous uv run contributor-network build step data only and adds npm run build to build the frontend. Allows the Python package to ship on PyPI without requiring npm/Node on consumer machines. Some smaller changes as a result: - Remove subprocess call from Python build command - Rename package to open-source-contributor-network (PyPI-unique name) - Drop unused jinja2 dependency - Update CI workflows to run both steps separately - Add test guarding the decoupling - Enrich PyPI metadata (license, authors, keywords, classifiers) ### For specific attention during review: - [ ] Is this what you had in mind with #124 ? - [ ] Metadata for PyPi publication, would you change anything? - [ ] Confirming no visual changes to the app (I tested and didn't see anything broken) - [ ] Do you think we should also change the name of the old uv run contributor-network build step to differentiate from npm run build or is the similarity acceptable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #125 — accidental merge