-
Notifications
You must be signed in to change notification settings - Fork 108
Feature/16 sparse #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
23df2af to
bee041e
Compare
d065376 to
f3a7d07
Compare
drewbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test expectations are a little off and made a comment there. Otherwise 👍
test/verify-sparse-labels.py
Outdated
|
|
||
| # our labels should look like this | ||
| expected_labels = { | ||
| '62092-50162-17': np.array([1, 0, 0, 0, 0, 0, 0]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually expect not to see this first one, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting it didn't cause checks to fail. That was weird, but it was because we just check that every tile in the npz file matches something in expected labels. I added a line (here and in vanilla verify-labels.py) to make sure that the number of tiles in label.npz and expected_labels also match
Closes #16
Todo:
@drewbo, continuing earlier discussion, algorithm looks like:
class_matchfromutils.pybackground_ratio * len(non_background_examples))