Skip to content

Conversation

@Geoyi
Copy link
Contributor

@Geoyi Geoyi commented Jan 22, 2018

showcase using label maker with Tensorflow object detection particularly.

@drewbo, can you review this code and document? I wanna make sure this code is pythonic enough, and if you could test it out that would be great too.

@drewbo
Copy link
Contributor

drewbo commented Jan 24, 2018

@Geoyi reading through and trying the demo now. Is there a way to write tf_records_generation.py so that it doesn't require pandas? It isn't required by the base library so I'd like to avoid it in the example (if possible)

@Geoyi
Copy link
Contributor Author

Geoyi commented Jan 24, 2018

theoretically yes @drewbo, but I only worked with dataframe/csv so far.

Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a few small changes inline. I'll come through afterwards and add the folder/text changes and fix some typos

cl_features = len([bb for l in labels for bb in l if bb[4] == i])
cl_tiles = len([l for l in labels if len(list(filter(_bbox_class(i), l)))]) # pylint: disable=cell-var-from-loop
cl_features = len([bb for l in labels for bb in l if bb[4] == i + 1])
cl_tiles = len([l for l in labels if len(list(filter(_bbox_class(i+1), l)))]) # pylint: disable=cell-var-from-loop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geoyi can you remove this commit? This change was already made on master so it's causing the merge conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I have resolved it, will doable check.

@@ -0,0 +1,153 @@
# Example Use: A building object detection with TensorFlow API

You have to walk through all these steps to be able to train a TensorFlow Object Detection and have the following results:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geoyi Can you add a short overview of what TensorFlow Object Detection API is and why we are using it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an overview has added to the head of the walkthrough too.

for bbox in bboxes:
if bbox[4] == 1:
cl_str = "building"
if bbox[0] < 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geoyi can you abstract this part out into a "clamping function" like I showed earlier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks for helping out, @drewbo

@drewbo drewbo merged commit b9459d8 into master Jan 30, 2018
@drewbo drewbo deleted the tf_object_detection branch January 30, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants