Table of contents #689
Table of contents #689
Conversation
|
Sorry @ATL2001 , I've been head-down on other projects the last few days, like https://github.com/developmentseed/object-store-rs. I'll review this in the next couple days 🙏 |
|
I totally understand that feeling. No worries, I actually don’t even have a use case currently for this personally, I see it’s usefulness and just figured I could help out a bit 😀(I had tinkered with something like this a while back, and just needed to abstract it a bit/ wire it into the codebase). If you or anyone else has any ideas how we could make a widget for the traits that are None when the TOC is created that would be great. I messed around with using an unchecked checkbox on initialization, but didn’t like the interactivity of it then disappearing and replacing it with another widget, it felt very hacky |
|
@ATL2001 I didn't mean to reject this PR; it was just more involved than I wanted to look at for inclusion into the latest release given my limited time to get a new release out. I see you deleted the repo; do you still have the work that had been on this branch? |
|
oh golly @kylebarron, it's not you, it's me. I didn't intend to yank this. I think I've mentioned before that I don't use github for work, so my skills here are a bit limited, I was trying to get rid of all my commit histories when I push in new updates, and when I was doing that, I messed some stuff up, so I decided to just start over from scratch before I went in to do that stuff for changing I think I did most of that from my macbook, so fingers crossed I still have the code there. I'll have to check that computer. |
|
HEY! I found it on that computer! I'll get it back in here at some point this week or weekend probably if you're still interested |
|
It would at least be nice to see again if you still have it. It would be nice to have a table of contents/legend widget |
2 participants
I've added the code for making a table of contents to the lonboard controls module, which seemed like the best place to put it to me.
I need to plead ignorance on the typing of the lonboard_map parameter of the make_TOC() function. I honestly don't have any idea how to get the lonboard.Map to be the type without causing a circular import error in the package. hopefully someone can help me out there!
For simplicity's sake, I've made the example notebook for the new functionality use as simple of geodataframes/layers as possible. hopefully that's ok.