ci(smoke): default FEDERATION_TEST_KEY when repo var is empty#63
Merged
Conversation
The smoke job passes FEDERATION_TEST_KEY via `${{ vars.FEDERATION_TEST_KEY }}`,
which expands to an empty string (not unset) when the variable is missing. The
previous `os.environ.get(key, default)` only applies the default when the var is
absent, so an empty value slipped through and the test GET hit the bucket root
(/federated-test/) instead of /federated-test/hello.txt. Use `or` to fall back.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alukach
changed the title
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The staging smoke run failed only on
test_federation.py, hitting/federated-test/with no object key.deploy.ymlpassesFEDERATION_TEST_KEY: ${{ vars.FEDERATION_TEST_KEY }}, which expands to an empty string (not unset) when the repo variable is missing. The test usedos.environ.get("FEDERATION_TEST_KEY", "hello.txt"), whose default only applies when the var is absent — so the empty value slipped through and the GET went to the bucket root instead of the object.Fix
Note: this only fixes the wrong-path bug. The federation smoke test will still be red until the one-time AWS setup is done (IAM OIDC provider for
STAGING_OIDC_ISSUER, trusting role, real role ARN + bucket inwrangler.deploy.toml, and the test object seeded in the private bucket).🤖 Generated with Claude Code