Skip to content

ci(smoke): default FEDERATION_TEST_KEY when repo var is empty #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alukach merged 1 commit into from
Jun 3, 2026
+4 −1
Merged

ci(smoke): default FEDERATION_TEST_KEY when repo var is empty #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/smoke/test_federation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@

DEPLOY_URL = os.environ.get("DEPLOY_URL", "http://localhost:8787").rstrip("/")
FEDERATION_BUCKET = "federated-test"
FEDERATION_TEST_KEY = os.environ.get("FEDERATION_TEST_KEY", "hello.txt")
# Use `or` (not a get() default): the workflow passes `${{ vars.FEDERATION_TEST_KEY }}`,
# which expands to "" — not unset — when the repo var is missing, and an empty key
# would GET the bucket root instead of the object.
FEDERATION_TEST_KEY = os.environ.get("FEDERATION_TEST_KEY") or "hello.txt"


def test_federation_serves_private_object():
Expand Down
Loading