Conversation
hrodmn
reviewed
Oct 31, 2025
There was a problem hiding this comment.
Thanks for sharing this! After our discussion this morning I experimented with a reader that caches the file to a MemoryStore then handles the read/seek operations on the file in memory:
class ObstoreMemCacheReader(ObstoreReader):
_reader: ReadableFile
_memstore: MemoryStore
def __init__(self, store: ObjectStore, path: str) -> None:
"""
Create an obstore file reader that caches the specified path
in a MemoryStore then performs reads from the file in memory.
----------
store
[ObjectStore][obstore.store.ObjectStore] for reading the file.
path
The path to the file within the store. This should not include the prefix.
"""
self._memstore = MemoryStore()
buffer = store.get(path).bytes()
self._memstore.put(path, buffer)
self._reader = obs.open_reader(self._memstore, path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @hrodmn