feat: Fsspec: Convert async methods that open sync file handles to use LocalStore#656
Merged
kylebarron merged 5 commits intodevelopmentseed:mainfrom Apr 3, 2026
Merged
Conversation
matteomorlack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR to fix sync usage in async methods that handles local filesystem.
For consistency an instance of the class with
fileas target fs is used and saved under acached_property.If this is not up to par with current code quality or there are any fixes to implement let me know and i'll gladly take a stab at it!
Should fix #258