Add member and moderator ids to listTeams response. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 13, 2020 13:32
kamicut
approved these changes
Apr 13, 2020
guidorice
pushed a commit
that referenced
this pull request
Apr 16, 2020
- Fixes a bug caused by #173 - listMembers() and listModerators() should not join with users table (they are just osm users, but probably not app users)
guidorice
pushed a commit
that referenced
this pull request
Apr 16, 2020
- Fixes a bug caused by #173 - listMembers() and listModerators() should not join with users table (they are just osm users, but probably not app users)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
Known issues
#/components/schemas/Teamis different depending whether the response is coming from/teamsor/teams/{id}. I could use suggestions what to do about that, or open an enhancement issue to track that discrepancy. (edit: see tracking issue Update OpenAPI spec to have correct /components/schemas/Team #175)