Skip to content

Conversation

@guidorice
Copy link

Closes #502

Alex G Rice added 3 commits April 13, 2020 16:38
- previously the exception was TypeError: column.Header is undefined
- the format of hashtags should be enforced by the api and database, not as a formatting task.
- opened issue developmentseed/osm-teams#174
- we prefer to display hashtags without # prefix.
@guidorice guidorice self-assigned this Apr 13, 2020
@guidorice guidorice marked this pull request as ready for review April 16, 2020 22:58
@guidorice guidorice requested a review from kamicut April 16, 2020 23:00
Copy link
Member

@kamicut kamicut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for the new route? Other than that it looks good!

@guidorice guidorice requested a review from kamicut April 17, 2020 21:22
@guidorice guidorice merged commit 538a6d9 into develop Apr 20, 2020
@guidorice guidorice deleted the feature/teams-page-502 branch April 20, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull all public teams into Scoreboard

3 participants