-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add helm chart auth options. #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
985ef13 to
fa530fa
Compare
| @@ -0,0 +1,150 @@ | |||
| # Authorization configuration guide | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we push this into the docs directory to publish at developmentseed.org/stac-auth-proxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a bit out of context. We could move it into the docs but frame it as helm/kubernetes setup and include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the repo, is there anywhere else that this information would be surfaced?
I'd ideally like for people to be able to think about this tool as a packaged product rather than just a codebase, hence my view that docs should be available outside of the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the repo, is there anywhere else that this information would be surfaced?
I'd ideally like for people to be able to think about this tool as a packaged product rather than just a codebase, hence my view that docs should be available outside of the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to move it to the docs. Perhaps good to bring in #117 first? After that I can combine README and AUTHORIZATION into one file in the docs.
helm/values.yaml
Outdated
| mode: "default" | ||
|
|
||
| # Custom endpoint configurations (only used when mode: "custom") | ||
| publicEndpoints: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this (and the privateEndpoints) override the defaults established within the stac auth proxy's configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would just set an env variable with the contents specified here. So, to my understanding, yes, if these are set, they will override them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified a bit better in the comments.
adab675 to
e9a6cea
Compare
e9a6cea to
d37cee3
Compare
This PR adds the following authorization options to the helm chart:
Manual configuration via environment variables and manual mount of filter files is still possible.
The PR requires #114 and #117.
I open this as a draft, as I expect us to have a few iterations and conversations about this.