Compute the name of the built jar in the Dockerfile #16
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dockerfile uses pom.xml values from maven - artifactId, and version used to find built jar
maysunfaisal
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Dockerfile to use the artifactId, and version output by maven to determine the name of the built jar.
The issue is that if the user changes the version or artifactId in the pom, the old Dockerfile hardcoded these names as
demoand0.0.1-SNAPSHOT. If these are changed in the pom.xml, the docker build would fail in attempting to copy the jar as the name would be incorrect.This change copies the built file to a known location and copies that to the /app directory in the run layer.