Add --no-port-detection flag to compose command#19
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 66.56% 66.26% -0.31%
==========================================
Files 10 11 +1
Lines 1358 1405 +47
==========================================
+ Hits 904 931 +27
- Misses 394 414 +20
Partials 60 60
☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike-hoang, thepetk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: thepetk <thepetk@gmail.com>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
What does this PR do?
This PR is part of the devfile/api#1153 EPIC and introduces a new optimization to the port detection logic. The new flag we are creating on the
componentcommand is calledno-port-detection/nand simply skips the port detection part of the command.In order to do that upon
getPortDetectionStrategyfunc of packagecomponentit checks if the global varnoPortDetectionis true. If yes it applies an early return with an emptymodel.PortDetectionAlgorithmlist.Test cases have been added inside the new
component_test.gofile also updates have been made to the documentation.As mentioned inside the proposal of the 1153 EPIC, we also add deprecation warning for the usage of port detection strategies.
Which issue(s) does this PR fix
fixes devfile/api#1150
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
I've calculated the time of execution for the new feature by running alizer against https://github.com/openshift/hypershift
With port detection:
Without port detection: