Skip to content

Add alizer binary to gitignore#20

Merged
thepetk merged 1 commit intodevfile:mainfrom
thepetk:ignore_alizer_binary
Aug 10, 2023
Merged

Add alizer binary to gitignore#20
thepetk merged 1 commit intodevfile:mainfrom
thepetk:ignore_alizer_binary

Conversation

@thepetk
Copy link
Contributor

@thepetk thepetk commented Aug 10, 2023

What does this PR do?

Simply adds the alizer filename inside gitignore file. This way we can ignore the alizer binary in case is built

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk requested a review from mike-hoang August 10, 2023 14:13
@thepetk thepetk self-assigned this Aug 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mike-hoang, thepetk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (45e6eac) 66.56% compared to head (cec88a7) 66.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files          10       10           
  Lines        1358     1358           
=======================================
  Hits          904      904           
  Misses        394      394           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk thepetk merged commit 8cd7239 into devfile:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants