Detect devfiles only for main language in case of no component found#22
Merged
thepetk merged 5 commits intodevfile:mainfrom Aug 22, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 66.26% 67.23% +0.96%
==========================================
Files 11 11
Lines 1405 1419 +14
==========================================
+ Hits 931 954 +23
+ Misses 414 405 -9
Partials 60 60
☔ View full report in Codecov by Sentry. |
thepetk
changed the title
mike-hoang
reviewed
Aug 21, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
bug/fix_component_detection
branch
from
58b02bf to
277dc75
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Contributor
Author
|
I've added more test cases in order to avoid having errors from the coverage reports |
mike-hoang
approved these changes
Aug 22, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike-hoang, thepetk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the logic of
SelectDevfilesFromTypesin order to match devfiles only for the main language of a source code if no component was found.More detailed, upon
SelectDevfilesFromTypes, if no component is found from the component analysis, it tries to match a devfile with the main language of the source code.Which issue(s) does this PR fix
fixes devfile/api#1219
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer