Skip to content

Conversation

@johnmcollier
Copy link
Member

@johnmcollier johnmcollier commented Jan 15, 2021

See https://github.com/devfile/api/blob/master/docs/proposals/versioning-and-release.md for the overall release process

This PR bumps the schema version on master from 2.0.0 to 2.1.0-alpha.

Signed-off-by: John Collier <jcollier@redhat.com>
@amisevsk
Copy link
Contributor

amisevsk commented Jan 15, 2021

It looks like the schema tests weren't updated to accommodate #289. Ideally this shouldn't be a failure since increasing the max length on a field is a backwards-compatible change.

@johnmcollier
Copy link
Member Author

@amisevsk Should be fixed by #307

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, elsony, johnmcollier, l0rd
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier johnmcollier merged commit f3fa280 into master Jan 18, 2021
@johnmcollier johnmcollier deleted the 2.1.0-alpha branch January 18, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants