-
Notifications
You must be signed in to change notification settings - Fork 66
Add endpoint annotations to DWR CRD; support endpoint annotations in basic solver #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint annotations to DWR CRD; support endpoint annotations in basic solver #1297
Conversation
fix devfile#1292 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Fix devfile#1296 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
…orted Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
…rted Devfile API docs Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
67a79fe to
209b3b3
Compare
dkwon17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I've tested on both minikube and CRC
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AObuchow, dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the review @dkwon17 :) Let's have this merged for DWO 0.31 |
What does this PR do?
What issues does this PR fix or reference?
Fix #1292 & fix #1296
Is it tested? How?
Testing on both Minikube (Kubernetes) and Openshift is recommended, since ingresses are created on Kubernetes and routes are created on OpenShift.
quay.io/aobuchow/devworkspace-controller:endpoint-annotations-implementationFor instance, on minikube, the created ingresses are called
<workspace-id>-endpoint-1&<workspace-id>-endpoint-2respectively. Checking their annotations shows:PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che