Skip to content

Conversation

@dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Feb 20, 2025

What does this PR do?

Installs gettext so that envsubst is available in the e2e test image.

What issues does this PR fix or reference?

Fixes error in the e2e tests:

ERROR: Program envsubst is required for this script

#1369 (comment)

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: David Kwon <dakwon@redhat.com>
@dkwon17 dkwon17 requested a review from ibuziuk as a code owner February 20, 2025 05:01
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit 6acf15d into main Feb 20, 2025
8 of 10 checks passed
@dkwon17 dkwon17 deleted the fix-e2e-test branch February 20, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants