Skip to content

Conversation

@liranr23
Copy link
Contributor

@liranr23 liranr23 commented Mar 3, 2025

Changed the Dockerfile to support multiarch golang builds.

What does this PR do?

  • Add support to multi-arch builds of project-clone image.

What issues does this PR fix or reference?

Is it tested? How?

  • Tested locally by checking printf of the args.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2025

Hi @liranr23. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liranr23, tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor

tolusha commented Mar 19, 2025

Hi @liranr23
Thank you for contribution.
Could you pick up the latest changes from remote/main.
I've just merged the RP #1403 to fix GitHub action

Changed the Dockerfile to support multiarch golang builds.

Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2025

New changes are detected. LGTM label has been removed.

@dkwon17 dkwon17 merged commit 1e29e0c into devfile:main Mar 21, 2025
10 checks passed
@liranr23 liranr23 deleted the clone_arm branch March 23, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants