Skip to content

Conversation

@nanjingfm
Copy link

What does this PR do?

This PR fixes the issue with compiling the project-clone binary. Previously, it could only run in a linux/amd64 environment.

企业微信截图_56672fc5-5e45-4a7c-a10f-8a6be19d5acb

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: mingfu <mingfu@alauda.io>
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nanjingfm
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

Hi @nanjingfm. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dkwon17
Copy link
Collaborator

dkwon17 commented Mar 21, 2025

Hello @nanjingfm thank you for the contribution. We've had a similar PR that was created recently: #1396 which introduces build support for multi architectures.

If #1396 isn't enough for your use case, please reopen this PR.

@dkwon17 dkwon17 closed this Mar 21, 2025
@nanjingfm nanjingfm deleted the fix/project-clone-dockerfile branch March 22, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants