-
Notifications
You must be signed in to change notification settings - Fork 66
chore: Add hostUsers field to DWOC #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
dkwon17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, rohanKanojia, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Add hostUsers field to DWOC
What issues does this PR fix or reference?
#1492
Is it tested? How?
OpenShift
UserNamespacesSupportfeature on the clusteroc patch FeatureGate cluster --type merge --patch '{"spec":{"featureSet":"CustomNoUpgrade","customNoUpgrade":{"enabled":["UserNamespacesSupport", "UserNamespacesPodSecurityStandards"]}}}'Wait for a while (
sleep 15m)oc create namespace testoc create role user-sa-scc --verb=use --resource=scc --resource-name=user-namespace -n test oc create rolebinding user-sa-scc --role=user-sa-scc --serviceaccount=test:user-sa --namespace=test oc create clusterrole dw-scc --verb=use,get,update --resource=scc --resource-name=user-namespace oc create clusterrolebinding dw-scc --clusterrole=dw-scc --serviceaccount=devworkspace-controller:devworkspace-controller-serviceaccountPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che