chore (deps) : update controller-runtime to v0.22.1

[rohanKanojia]

What does this PR do?

• Update Controller Runtime to v0.22.1
• Add unit test pull_secret_test.go for pull_secret.go (this is unrelated to controller-runtime changes, just wanted to check if we will be getting same failures as che-operator is getting due to controller-runtime upgrade. It turns out that che operator logic depended on the presence of TypeMeta, which was causing problems. I can either remove/move the commit to a new PR or keep it as it is. (Moved to test : add table-driven tests for PullSecrets with edge case coverage #1506)

As of now, we're using k8s.io/* dependencies in v0.34.0-alpha.1. With v0.22.1 they'll now point to v0.34.0

Signed-off-by: Rohan Kumar rohaan@redhat.com

What issues does this PR fix or reference?

Fix #1502

Is it tested? How?

• I verified the build is passing correctly. make test
• E2E tests are passing
• Basic flow is working (DevWorkspaces are getting created)
  • DevWorkspace manifest applied
  • DevWorkspace 'code-latest' is running
  • Project-clone logs streamed
  • File modified inside workspace
  • Workspace stopped
  • Workspace restarted and is running
  • Changes persisted after restart
  • Secondary DevWorkspace created
  • Secondary workspace stopped
  • First DevWorkspace deleted
  • PVC check pod created
  • PVC check pod is ready
  • PVC content verification passed
  • PVC check pod deleted
  • Second DevWorkspace deleted
  • Common DevWorkspace PVC removed

I also ran load tests with smaller input and didn't see any devworkspace failures:

# Deploy DWO from this branch then checkout load test branch
make test_load ARGS="--mode binary --max-vus 30 --create-automount-resources true --max-devworkspaces 100 --delete-devworkspace-after-ready false --separate-namespaces false --test-duration-minutes 15"

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rohanKanojia]

/ok-to-test

[tolusha]

I would double check all List operations.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.30%. Comparing base (8f2d764) to head (744ab69).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
+ Coverage   34.05%   34.30%   +0.24%     
==========================================
  Files         160      160              
  Lines       13336    13348      +12     
==========================================
+ Hits         4542     4579      +37     
+ Misses       8484     8457      -27     
- Partials      310      312       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[dkwon17]

I have tested this PR like so:

1. On an OpenShift 4.19 cluster, install Eclipse Che and DevWorkspace operator 0.36.0
2. Create a non-ephemeral workspace https://github.com/dkwon17/quarkus-api-example/tree/per-workspace
3. When the editor opens, make a change in the source code
4. Stop the workspace
5. Delete the DevWorkspace Operator and install the changes from this PR via catalog source (followed these steps to create my own image and catalog source image)
6. Install the new version of the DWO which includes the changes from this PR
7. Start the same workspace from step 2, and verified that the workspace runs correctly, and changes from step 3 have persisted

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment