Skip to content

Conversation

@Allda
Copy link
Collaborator

@Allda Allda commented Jan 28, 2026

The NeedsStorage always return false for per-wokrspace storage. This causes an issue and per-workspace workspaces are never backed up.

Moving the check to commonStorage only fixes the issue and still works with empty workspaces.

Fixes: #1575

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

The NeedsStorage always return false for per-wokrspace storage. This
causes an issue and per-workspace workspaces are never backed up.

Moving the check to commonStorage only fixes the issue and still works
with empty workspaces.

Signed-off-by: Ales Raszka <araszka@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Allda
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@Allda: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-devworkspace-operator-e2e 2b21d40 link true /test v14-devworkspace-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backup functionality does not work for DevWorkspaces using per-workspace storage type.

2 participants