Change project-backup image from ubi10 to ubi9#1610
Change project-backup image from ubi10 to ubi9#1610dkwon17 wants to merge 1 commit intodevfile:mainfrom
Conversation
Signed-off-by: David Kwon <dakwon@redhat.com>
📝 WalkthroughWalkthroughThe base image for the containerized application was downgraded from UBI 10 to UBI 9 in the Containerfile, affecting the runtime environment and system package availability while maintaining all other configuration layers and setup procedures. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
project-backup/Containerfile (1)
17-17: Consider pinning to a specific UBI9 version for reproducibility.Using
:latestmeans builds may vary over time as UBI9 receives updates. For reproducible builds and easier rollback in case of issues, consider pinning to a specific UBI9 minor version or digest.📌 Example: Pin to a specific version
-FROM registry.access.redhat.com/ubi9:latest +FROM registry.access.redhat.com/ubi9:9.5-1234567890Or use a digest for immutability:
-FROM registry.access.redhat.com/ubi9:latest +FROM registry.access.redhat.com/ubi9@sha256:<digest>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@project-backup/Containerfile` at line 17, The Docker base image uses an unpinned tag in the Containerfile (FROM registry.access.redhat.com/ubi9:latest), which makes builds non-reproducible; replace the :latest tag with a specific UBI9 minor version or an image digest (immutable SHA) in the FROM instruction, and update any build docs or CI configs that reference this Containerfile to use the same pinned value so builds are reproducible and rollbackable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@project-backup/Containerfile`:
- Line 17: The Docker base image uses an unpinned tag in the Containerfile (FROM
registry.access.redhat.com/ubi9:latest), which makes builds non-reproducible;
replace the :latest tag with a specific UBI9 minor version or an image digest
(immutable SHA) in the FROM instruction, and update any build docs or CI configs
that reference this Containerfile to use the same pinned value so builds are
reproducible and rollbackable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 71f59af7-1722-4972-b7bf-8b5cddcc0bd7
📒 Files selected for processing (1)
project-backup/Containerfile
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Changes the base image for the project-backup image from ubi10 to ubi9 in order to align with the downstream project-backup image: https://catalog.redhat.com/en/software/containers/devworkspace/devworkspace-project-backup-rhel9/696e8281133dac5cafd0e594
What issues does this PR fix or reference?
https://redhat.atlassian.net/jira/software/c/projects/CRW/issues/?selectedIssue=CRW-10033&jql=project%20%3D%20CRW%20ORDER%20BY%20created%20DESC
Is it tested? How?
Build the image, and deploy:
Verify that build is successful.
Next, enable the backup cron job, and verify that non-ephemeral workspaces are successfully being backed up. See https://eclipse.dev/che/docs/stable/administration-guide/devworkspace-backup-integrated-openshift-registry/ for docs on how to enable backups.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit
Release Notes