Introduce latest web terminal plugin version #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sleshchenko
force-pushed
the
wto-improvements
branch
from
8d531bb to
2c6cfb6
Compare
|
New changes are detected. LGTM label has been removed. |
sleshchenko
force-pushed
the
wto-improvements
branch
from
2c6cfb6 to
5216150
Compare
|
/test v5-devworkspaces-operator-e2e |
|
Adding volume to custom terminal tooling in moved to #360 |
sleshchenko
added a commit
to sleshchenko/devworkspace-operator
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's possible way to fix https://issues.redhat.com/browse/WTO-65, I'm a bit tired to see 4.5.0 on the all OpenShift versions. But we can't simply remove 4.5.0 versions not to break existing instances.
It will be needed to cherry-pick in to v1alphax branch if we decide it's a good idea.
What issues does this PR fix or reference?
https://issues.redhat.com/browse/WTO-65
Is it tested? How?
tested that web terminal started.