Add volume into custom web terminal sample #360
Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
This may cause a few other issues. Looking at the contents of the web terminal tooling container, without the entrypoint, I see
$ ls -al $HOME
total 20
drwxrwxr-x. 2 root root 4096 Feb 25 15:39 .
drwxr-xr-x. 1 root root 4096 Feb 25 15:38 ..
-rw-rw-r--. 1 root root 77 Feb 25 15:39 .bashrc
-rw-rw----. 1 root root 533 Feb 25 15:39 .viminfo
where .bashrc contains some completions. Mounting a volume into this path will wipe out these files.
We should update the web-terminal-tooling image to accomodate a mounted $HOME dir (e.g. by putting completions /tmp/home and copying over to the PVC on start.
I'm not sure why, but with the current PR, the /home/user directory is being created by root and not the running user 🤔
| - name: PS1 | ||
| value: \[\e[34m\]>\[\e[m\]\[\e[33m\]>\[\e[m\] | ||
| volumeMounts: | ||
| - path: "/home/" |
There was a problem hiding this comment.
Shouldn't we mount to /home/user?
There was a problem hiding this comment.
Changed to /home/user.
but actually, it's strange that I got permissions denied error when I try /home, somebody creates non-writable /home/user.
|
Created https://issues.redhat.com/browse/WTO-82 to track updates needed for the tooling image. |
|
@sleshchenko: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR redhat-developer/web-terminal-tooling#26 is merged so this should be good to go as soon as the change is propagated into the image. |
|
@amisevsk I tried the sample with the latest manually built tooling (quay.io/sleshche/web-terminal-tooling:latest) and it does not seem to work as expected: > kc logs workspace2ca8278ee0e3489f-7b6f75765d-dj2tn -c tooling
cp: cannot create regular file '/home/user/.bashrc': Permission deniedUpdate: |
sleshchenko
force-pushed
the
terminalWithVolume
branch
from
1a3eaa8 to
044d935
Compare
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
does nothing 😕 |
The bot LIES:
|
3 participants
What does this PR do?
Add volume into custom web terminal sample.
What issues does this PR fix or reference?
N/A
Is it tested? How?
Made sure that the sample work fine with the latest tooling image after redhat-developer/web-terminal-tooling#26 is merged.
It did not work for me with default latest WTO, so a dedicated issue is created https://issues.redhat.com/browse/WTO-89