Skip to content

Conversation

@ibuziuk
Copy link
Contributor

@ibuziuk ibuziuk commented Jan 18, 2022

Signed-off-by: Ilya Buziuk ibuziuk@redhat.com

What does this PR do?

Increasing the default PVCStorageSize to 10Gi

What issues does this PR fix or reference?

eclipse-che/che#21033

Is it tested? How?

Verified via cluster-bot 4.9.0-0.nightly-2022-01-17-165424

image

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: claim-devworkspace
  namespace: test
  uid: 9dfff810-a3c6-46b1-aea2-ff9517016de6
  resourceVersion: '27025'
  creationTimestamp: '2022-01-18T11:25:54Z'
  annotations:
    pv.kubernetes.io/bind-completed: 'yes'
    pv.kubernetes.io/bound-by-controller: 'yes'
    volume.beta.kubernetes.io/storage-provisioner: kubernetes.io/gce-pd
    volume.kubernetes.io/selected-node: ci-ln-3vili0t-72292-x6sft-worker-b-p588l
  finalizers:
    - kubernetes.io/pvc-protection
  managedFields:
    - manager: main
      operation: Update
      apiVersion: v1
      time: '2022-01-18T11:25:54Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:spec':
          'f:accessModes': {}
          'f:resources':
            'f:requests':
              .: {}
              'f:storage': {}
          'f:volumeMode': {}
    - manager: kube-scheduler
      operation: Update
      apiVersion: v1
      time: '2022-01-18T11:26:02Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            .: {}
            'f:volume.kubernetes.io/selected-node': {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: v1
      time: '2022-01-18T11:26:04Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            'f:pv.kubernetes.io/bind-completed': {}
            'f:pv.kubernetes.io/bound-by-controller': {}
            'f:volume.beta.kubernetes.io/storage-provisioner': {}
        'f:spec':
          'f:volumeName': {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: v1
      time: '2022-01-18T11:26:04Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:status':
          'f:accessModes': {}
          'f:capacity':
            .: {}
            'f:storage': {}
          'f:phase': {}
      subresource: status
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 10Gi
  volumeName: pvc-9dfff810-a3c6-46b1-aea2-ff9517016de6
  storageClassName: standard
  volumeMode: Filesystem
status:
  phase: Bound
  accessModes:
    - ReadWriteOnce
  capacity:
    storage: 10Gi

On CRC 4.8.5 there is a weird situation with capacity allocation for any PVC which defaults to 100GI for some reason.
the storage request is set correctly though:

image

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested a review from amisevsk as a code owner January 18, 2022 10:53
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@musienko-maxim
Copy link
Collaborator

/test v8-devworkspace-operator-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants