Update to Go 1.19 #212
Update to Go 1.19 #212
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 7 7
Lines 2012 2012
=======================================
Hits 548 548
Misses 1417 1417
Partials 47 47 ☔ View full report in Codecov by Sentry. |
michael-valdron
force-pushed
the
golang-1-19
branch
from
1077875 to
0f80fb1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine AS base | ||
| COPY --from=goreleaser-xx / / | ||
| RUN apk add --no-cache file git | ||
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| COPY --from=goreleaser-xx / / | ||
| RUN apk add --no-cache file git | ||
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| ENV CGO_ENABLED=0 | ||
| WORKDIR /go/src/github.com/docker/distribution | ||
|
|
||
| FROM base AS version |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| COPY --from=build /usr/local/bin/registry* / | ||
| COPY --from=build /usr/bin/registry / | ||
|
|
||
| FROM base AS releaser |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| COPY --from=releaser /out / | ||
|
|
||
| FROM alpine:3.14 | ||
| FROM alpine:${ALPINE_VERSION} |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
golang-1-19
branch
from
0f80fb1 to
e2b0944
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
golang-1-19
branch
from
c54cc1d to
2695d60
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
golang-1-19
branch
from
d7f6da1 to
9793409
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Not needed for these changes. |
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
/lgtm I was able to build the registry image locally.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold In order to merge this without problems with our community registry deploy, I'll need to block updates to the |
Opened PR under devfile/registry to freeze the state of |
|
/unhold devfile/registry#316 has been merged and community registry reference to this repository is frozen until devfile/api#1473 is resolved. |
2 participants
Please specify the area for this PR
What does does this PR do / why we need it:
Updates registry support services to Go 1.19 with dependency updates.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1469
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: