Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 12, 2024

Please specify the area for this PR

What does does this PR do / why we need it:

Refactor out io/ioutil module as part of Go 1.19 upgrade #212.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#1469

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot requested review from elsony and thepetk March 12, 2024 20:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 27.27%. Comparing base (e51ee89) to head (d0cdba7).

Files Patch % Lines
index/server/pkg/server/endpoint.go 84.61% 2 Missing ⚠️
index/server/pkg/util/util.go 60.00% 2 Missing ⚠️
index/server/pkg/server/index.go 0.00% 1 Missing ⚠️
index/server/pkg/server/registry.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   27.23%   27.27%   +0.04%     
==========================================
  Files           7        7              
  Lines        2012     2009       -3     
==========================================
  Hits          548      548              
+ Misses       1417     1414       -3     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-valdron
Copy link
Member Author

Does the REST API doc need to be updated with your changes?
Does the registry library doc need to be updated with your changes?

N/A

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 9445a83 into devfile:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants