feature(shopify): add followup query analytics #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vid277
commented
Apr 1, 2025
vid277
commented
skeptrunedev
requested changes
Apr 1, 2025
| Object.keys(lastMessage)[0] || "00000000-0000-0000-0000-000000000000"; | ||
|
|
||
| await trieveSDK.sendAnalyticsEvent({ | ||
| event_name: `site-followup_query`, |
Contributor
There was a problem hiding this comment.
I believe that either this one or the one before is not a followup but rather an initial suggestion?
Contributor
There was a problem hiding this comment.
I think we should track these too
densumesh
requested changes
Apr 1, 2025
|
|
||
| await trieveSDK.sendAnalyticsEvent({ | ||
| event_name: `site-followup_query`, | ||
| event_type: "followup_query", |
Contributor
There was a problem hiding this comment.
Don't create a new event_type just use the click event with that name
drew-harris
reviewed
Apr 1, 2025
| client.prefetchQuery( | ||
| popularSuggestedQueriesQuery(trieve, filters, page + 1), | ||
| ); | ||
| }, [page]); |
Contributor
There was a problem hiding this comment.
filters should be in the dependency array
skeptrunedev
requested changes
Apr 1, 2025
densumesh
force-pushed
the
vs/shopify-feature-popular-follow-up
branch
from
3b27d6f to
104f077
Compare
densumesh
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.