Feature/admin forth/1281/let's add hard limit to transl#12
Merged
yaroslav8765 merged 12 commits intomainfrom Mar 3, 2026
Merged
Conversation
…r translation requests
ivictbor
commented
Feb 25, 2026
| let stringBanch = []; | ||
| let banchTokens = 0; | ||
| for (const string of stringsToTranslate) { | ||
| if( banchTokens + enStringsTokenLengthCache[string] <= allowedTokensAmountForFields ) { |
Contributor
Author
There was a problem hiding this comment.
if string is e.g. 4 KiB then indexing by such string kills CPU, do we have uuid to address? and not using en_string?
BREAKING CHANGE: need to use background jobs plugin for translations
…obs for translation tasks
…proved task handling and UI updates
There was a problem hiding this comment.
Pull request overview
This PR moves bulk translation generation to a BackgroundJobs-based workflow with configurable batching/parallelism, and updates the UI to run “translate filtered” as a background job with task progress details.
Changes:
- Add plugin options to control translation batching size (
inputTokensPerBatch) and parallel request limit (parallelTranslationLimit). - Replace synchronous bulk translation with BackgroundJobs tasks and a custom job details Vue component.
- Add a backend endpoint to fetch filtered record IDs so the UI can translate “filtered” items.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
types.ts |
Adds new plugin options for batch token limit and parallel translation concurrency. |
package.json |
Adds p-limit dependency to support concurrency limiting. |
package-lock.json |
Locks p-limit@7.3.0 (Node engine >= 20) and its new dependency graph. |
index.ts |
Refactors translation into background tasks, registers handler/UI component, adds get_filtered_ids endpoint, updates list injection location. |
custom/TranslationJobViewComponent.vue |
New job details UI showing token totals and per-task status via websocket updates. |
custom/BulkActionButton.vue |
Updates bulk action to “Translate filtered”, fetches filtered IDs, and refreshes list on progress websocket events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.