Skip to content

Feature/admin forth/1281/let's add hard limit to transl#12

Merged
yaroslav8765 merged 12 commits intomainfrom
feature/AdminForth/1281/let's-add-hard-limit-to-transl
Mar 3, 2026
Merged

Feature/admin forth/1281/let's add hard limit to transl#12
yaroslav8765 merged 12 commits intomainfrom
feature/AdminForth/1281/let's-add-hard-limit-to-transl

Conversation

@ivictbor
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread index.ts Outdated
Comment thread index.ts
Comment thread index.ts Outdated
let stringBanch = [];
let banchTokens = 0;
for (const string of stringsToTranslate) {
if( banchTokens + enStringsTokenLengthCache[string] <= allowedTokensAmountForFields ) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if string is e.g. 4 KiB then indexing by such string kills CPU, do we have uuid to address? and not using en_string?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves bulk translation generation to a BackgroundJobs-based workflow with configurable batching/parallelism, and updates the UI to run “translate filtered” as a background job with task progress details.

Changes:

  • Add plugin options to control translation batching size (inputTokensPerBatch) and parallel request limit (parallelTranslationLimit).
  • Replace synchronous bulk translation with BackgroundJobs tasks and a custom job details Vue component.
  • Add a backend endpoint to fetch filtered record IDs so the UI can translate “filtered” items.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
types.ts Adds new plugin options for batch token limit and parallel translation concurrency.
package.json Adds p-limit dependency to support concurrency limiting.
package-lock.json Locks p-limit@7.3.0 (Node engine >= 20) and its new dependency graph.
index.ts Refactors translation into background tasks, registers handler/UI component, adds get_filtered_ids endpoint, updates list injection location.
custom/TranslationJobViewComponent.vue New job details UI showing token totals and per-task status via websocket updates.
custom/BulkActionButton.vue Updates bulk action to “Translate filtered”, fetches filtered IDs, and refreshes list on progress websocket events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread index.ts
Comment thread index.ts
Comment thread custom/TranslationJobViewComponent.vue Outdated
Comment thread index.ts
Comment thread index.ts
Comment thread custom/BulkActionButton.vue
Comment thread index.ts
Comment thread index.ts
Comment thread index.ts
Comment thread index.ts
@yaroslav8765 yaroslav8765 merged commit 069661b into main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants