Skip to content

feat: move login error message to the bottom of authentication modal #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

feat: move login error message to the bottom of authentication modal #388

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f865470
feat: move login error message to the bottom of authentication modal
yaroslav8765 Oct 10, 2025
ce6d14f
fix: fix login error message positioning
yaroslav8765 Oct 10, 2025
0a9c3f5
fix: fix padding for the login error message
yaroslav8765 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions adminforth/spa/src/views/LoginView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
overflow-x-hidden z-50 min-w-[350px] justify-center items-center md:inset-0 h-[calc(100%-1rem)] max-h-full">
<div class="relative p-4 w-full max-h-full max-w-[400px]">
<!-- Modal content -->
<div class="af-login-modal-content relative bg-lightLoginViewBackground rounded-lg shadow dark:bg-darkLoginViewBackground dark:shadow-black" >
<div class="af-login-modal-content relative bg-lightLoginViewBackground rounded-lg shadow dark:bg-darkLoginViewBackground dark:shadow-black" :class=" { 'rounded-b-none overflow-hidden': error } ">
<!-- Modal header -->
<div class="af-login-modal-header flex items-center justify-between flex-col p-4 md:p-5 border-b rounded-t dark:border-gray-600">

Expand Down Expand Up @@ -92,8 +92,6 @@
:meta="c.meta"
@update:disableLoginButton="setDisableLoginButton($event)"
/>

<ErrorMessage :error="error" />

<div v-if="loginPromptHTML"
class="flex items-center p-4 mb-4 text-sm text-lightLoginViewPromptText rounded-lg bg-lightLoginViewPromptBackground dark:bg-darkLoginViewPromptBackground dark:text-darkLoginViewPromptText" role="alert"
Expand All @@ -108,9 +106,9 @@
{{ $t('Login to your account') }}
</Button>
</form>

</div>
</div>
<ErrorMessage v-if="error" :error="error" class="absolute left-4 right-4 rounded-t-none mb-0 shadow px-9" />
</div>
</div>

Expand Down