fix: refactor model generation for generate-models command to use cal… #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
requested changes
Oct 13, 2025
|
|
||
| for (const file of files) { | ||
| if (file.endsWith(".js") || file.endsWith(".ts")) { | ||
| const instance = await getInstance(file, currentDirectory); |
Contributor
There was a problem hiding this comment.
@yaroslav8765 lets get rid of getInstance in codebase at all if it is not used in any other commands, exec( function should have instance
| const columns = ${JSON.stringify(resource.columns)}; | ||
| const typeName = "${typeName}"; | ||
| function mapToTypeScriptType(type) { | ||
| const map = { "int": "number", "varchar": "string", "boolean": "boolean" }; |
Contributor
There was a problem hiding this comment.
@yaroslav8765 I think we have more data types https://adminforth.dev/docs/api/Common/enumerations/AdminForthDataTypes/#enumeration-members
ivictbor
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lTsProxy