Skip to content

Fix virtual columns sorting #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivictbor merged 4 commits into from
Jan 7, 2025
Merged

Fix virtual columns sorting #53

ivictbor merged 4 commits into from
Jan 7, 2025

Conversation

@mamchurovskyy
Copy link
Contributor

@mamchurovskyy mamchurovskyy commented Jan 7, 2025

  1. If "virtual: true" than default "sortable: false" -> sort icon is hidden by default for such column;
  2. Filter virtual columns from sort array before DB request to avoid 500 -> users should add sort clauses by themselves with "list.beforeDataSourceRequest" hook

ivictbor
ivictbor approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ivictbor ivictbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivictbor ivictbor merged commit 8323c53 into main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivictbor ivictbor ivictbor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mamchurovskyy @ivictbor