Skip to content

fix: rename readonly prop in select and date picker #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: rename readonly prop in select and date picker #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions adminforth/spa/src/afcl/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<input
ref="inputEl"
type="text"
:readonly="isReadonly"
:readonly="readonly"
v-model="search"
@click="inputClick"
@input="inputInput"
Expand Down Expand Up @@ -102,7 +102,7 @@ const props = defineProps({
type: String,
default: '',
},
isReadonly: {
readonly: {
type: Boolean,
default: false,
},
Expand Down Expand Up @@ -147,7 +147,7 @@ function updateFromProps() {
}

function inputClick() {
if (props.isReadonly) return;
if (props.readonly) return;
// Toggle local dropdown
showDropdown.value = !showDropdown.value;
// If the dropdown is about to close, reset the search
Expand Down
6 changes: 3 additions & 3 deletions adminforth/spa/src/components/CustomDatePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<input ref="datepickerStartEl" type="text"
class="bg-gray-50 border leading-none border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-blue-500 focus:border-blue-500 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-blue-500 dark:focus:border-blue-500"
:placeholder="$t('Select date')" :disabled="isReadonly" />
:placeholder="$t('Select date')" :disabled="readonly" />

</div>
</div>
Expand All @@ -27,7 +27,7 @@

<input v-model="startTime" type="time" id="start-time" onfocus="this.showPicker()" onclick="this.showPicker()" step="1"
class="bg-gray-50 border leading-none border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-blue-500 focus:border-blue-500 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-blue-500 dark:focus:border-blue-500"
value="00:00" :disabled="isReadonly" required/>
value="00:00" :disabled="readonly" required/>
</div>
</div>
</div>
Expand Down Expand Up @@ -72,7 +72,7 @@ const props = defineProps({
autoHide: {
type: Boolean,
},
isReadonly: {
readonly: {
type: Boolean,
},
});
Expand Down