Skip to content

OCUA-11 Multiple contract winner (i077) flag appears funny #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpostelnicu merged 1 commit into from
May 2, 2017
Merged

OCUA-11 Multiple contract winner (i077) flag appears funny #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions web/src/main/java/org/devgateway/ocds/web/flags/release/ReleaseFlagI077Processor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class ReleaseFlagI077Processor extends AbstractFlaggedReleaseFlagProcesso
frequentSuppliersMap;

private Date now;
private Double nowDouble;

@Autowired
private FrequentSuppliersTimeIntervalController frequentSuppliersTimeIntervalController;
Expand All @@ -45,8 +46,8 @@ protected void setFlag(Flag flag, FlaggedRelease flaggable) {
}

protected Integer getInterval(Date awardDate) {
return new Double(Math.ceil((now.getTime() - awardDate.getTime())
/ (GenericOCDSController.DAY_MS * INTERVAL_DAYS))).intValue();
return new Double(Math.ceil((nowDouble - awardDate.getTime())
/ GenericOCDSController.DAY_MS / INTERVAL_DAYS)).intValue();
}

@Override
Expand All @@ -59,7 +60,7 @@ protected Boolean calculateFlag(FlaggedRelease flaggable, StringBuffer rationale
supplier.getId(), getInterval(award.getDate()))
))
).map(award -> rationale
.append("Award ").append(award.getId()).append(" flagged"))
.append("Award ").append(award.getId()).append(" flagged; "))
.count() > 0;
}

Expand All @@ -70,6 +71,7 @@ protected Boolean calculateFlag(FlaggedRelease flaggable, StringBuffer rationale
@Override
public void reInitialize() {
now = new Date();
nowDouble = new Double(now.getTime());
List<FrequentSuppliersTimeIntervalController.FrequentSuppliersResponse> frequentSuppliersTimeInterval
= frequentSuppliersTimeIntervalController.frequentSuppliersTimeInterval(getIntervalDays(),
getMaxAwards(), now);
Expand Down